DRAFT [SS-148]: Iceberg Sink, don't retry commit unless it's definitely not a duplicate - #38333
Draft
ublubu wants to merge 6 commits into
Draft
DRAFT [SS-148]: Iceberg Sink, don't retry commit unless it's definitely not a duplicate#38333ublubu wants to merge 6 commits into
ublubu wants to merge 6 commits into
Conversation
ublubu
force-pushed
the
iceberg-double-committed
branch
from
August 19, 2026 17:32
e7af868 to
df87fbd
Compare
Claude: on both retrial paths, check for other writers Human: rewrite comments
ublubu
force-pushed
the
iceberg-double-committed
branch
from
August 19, 2026 18:19
df87fbd to
4da11f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if we committed to Iceberg but lost the success response:
iceberg-rustreloads the table from the catalog and rebases our transaction onto the latest version of the table.With this PR, if we don't know what happened to our commit, we do not proceed until we've successfully reloaded the table.
Also new with this PR: If the commit error wasn't "Conflict" or "Unknown", consider it a definite, fatal error.